NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

update minreal unit test to use poles/zeros instead of num/den#220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

murrayrm merged 1 commit intopython-control:masterfrommurrayrm:fix_minreal_test

Jul 7, 2018

Merged

update minreal unit test to use poles/zeros instead of num/den#220

murrayrm merged 1 commit intopython-control:masterfrommurrayrm:fix_minreal_test

Jul 7, 2018

+29 −15

Conversation

Copy link

Member

murrayrm commentedJul 7, 2018

This PR fixes issue#217 by using a better test to see ifminreal() is operating correctly: instead of checking whether transfer functions are the same, we check whether poles and zeros are the same. (This avoids some simplifications than can happen in the transformation of state space objects to transfer function objects.)