- Notifications
You must be signed in to change notification settings - Fork441
Fix canonical form 'observable'#200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedApr 18, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
coveralls commentedApr 18, 2018
control/canonical.py Outdated
| @@ -133,7 +133,7 @@ def observable_form(xsys): | |||
| Wrz = obsv(zsys.A, zsys.C) | |||
| # Transformation from one form to another | |||
| Tzx = inv(Wrz) * Wrx | |||
| Tzx =solve(Wrz, Wrx) # matrix right division, Tzx =inv(Wrz) * Wrx | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, this looks right. I see there are no tests for observable_form - would you mind adding one?
This would be left division inMatlab's terminology
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you are right. See my update
Minor fix to use 'solve' instead of 'inv'.
Asserts with prio 'inv' from (numpy.linalg.inv was also not imported, yet not needed anymore)