Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bode margins plot#199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 5 commits intopython-control:masterfromicam0:bode_margins_plot
Dec 28, 2018
Merged

Conversation

icam0
Copy link
Contributor

Added display of the phase and gain margins to the bode plots in order to emulate matlab like functionality when calling margin(sys) in matlab. Can be used when calling bode(sys, margins=True). Attached 2 screenshots showing the plots in matplotlib and matlab side by side.

figure_1_matlab
figure_1_python

@coveralls
Copy link

coveralls commentedMar 31, 2018•
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 78.936% when pulling991daf4 on icam0:bode_margins_plot intoa007fcc on python-control:master.

@icam0
Copy link
ContributorAuthor

Build seems to be failing due to issue#194

@repagh
Copy link
Member

I don't see what the

import sys as system

line is for. Seems not to be used, and renaming it system is not a good idea in this context

@icam0
Copy link
ContributorAuthor

@repagh , you are right. I suspect this was a leftover from some testing on my part. I removed it.

@murrayrmmurrayrm added this to the0.8.1 milestoneJun 30, 2018
@murrayrm
Copy link
Member

Note: this PR has been included in PR#209. If that PR is merged, can delete this one.

@murrayrmmurrayrm modified the milestones:0.8.1,0.8.2Jul 18, 2018
@murrayrmmurrayrm merged commit4286329 intopython-control:masterDec 28, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.

4 participants
@icam0@coveralls@repagh@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp