Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix margin() documentation to address issue #195#198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 3 commits intopython-control:masterfrommurrayrm:fix_margins_doc
Jul 2, 2018

Conversation

murrayrm
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commentedFeb 24, 2018
edited
Loading

Coverage Status

Coverage remained the same at 77.882% when pulling9fd6ae7 on murrayrm:fix_margins_doc into601b581 on python-control:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.882% when pulling9fd6ae7 on murrayrm:fix_margins_doc into601b581 on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.882% when pulling9fd6ae7 on murrayrm:fix_margins_doc into601b581 on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.882% when pulling9fd6ae7 on murrayrm:fix_margins_doc into601b581 on python-control:master.

@coveralls
Copy link

coveralls commentedFeb 24, 2018
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 78.395% when pulling1593391 on murrayrm:fix_margins_doc into601b581 on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.882% when pulling9fd6ae7 on murrayrm:fix_margins_doc into601b581 on python-control:master.

@murrayrmmurrayrm mentioned this pull requestMar 11, 2018
Wcp : float
Phase crossover frequency (corresponding to gain margin) (in rad/sec)
wg: float
Gain margin crossover frequency (where phase crosses -180 degrees)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why not omit "crossover" altogether? The parenthetical remarks are helpful -- I always get these mixed up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I must admit that the Mathworks explanation is nice herehttps://www.mathworks.com/help/control/ref/margin.html

I don't agree with the terminology as you now propose.

Gain crossover frequency is where gain is (crosses!) 0dB -- corresponds to gain margin
we can call it Wgco or Wpm

Phase crossover (frequency) is where phase crosses -180 deg -- corresponds to phase margin
We can call it Wpco or wg

Gain margin crossover is simply confusing

Maybe say:
wg: frequency at gain margin (phase crossover point, phase = -180 deg)
wp: frequency at phase margin (gain crossover point, gain = 0dB)

@murrayrmmurrayrm added this to the0.8.0 milestoneJun 30, 2018
@repagh
Copy link
Member

@murrayrm, I added a commit on this PR. I also edited comments for the related stability_margins function.

@murrayrmmurrayrm merged commit5158a39 intopython-control:masterJul 2, 2018
@murrayrmmurrayrm deleted the fix_margins_doc branchJuly 2, 2018 21:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@roryyorkeroryyorkeroryyorke left review comments

@repaghrepaghrepagh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

4 participants
@murrayrm@coveralls@repagh@roryyorke

[8]ページ先頭

©2009-2025 Movatter.jp