NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

Travis CI update for new/old scipy + improved slycot#169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

murrayrm merged 2 commits intopython-control:masterfrommurrayrm:fix_travis

Jan 2, 2018

Merged

Travis CI update for new/old scipy + improved slycot#169

murrayrm merged 2 commits intopython-control:masterfrommurrayrm:fix_travis

Jan 2, 2018

Conversation

Copy link

Member

murrayrm commentedDec 23, 2017

This PR addresses two related issues:

The current version of python-control is incompatible withscipy-1.0.0 and so all checks are failing. In this build script we do explicit checks againstscipy-0.19.0 andscipy-1.0.0. This is related to issueCompatibility issue with SciPy 1.0 #164.
The way that tests were being done against slycot, they were actually not checking to make sure slycot was installed correctly => they 'succeeded' if slycot failed to install. The new version of the build script separates out the slycot versus non-slycot builds so that this is more obvious. IssueSlycot installation failing in Travis CI #168 describes the issue.

In addition to these changes, I updated the python version numbers to check against to 2.7, 3.5, and 3.6 (versions 3.3 and 3.4 seem old enough that we can stop checking against them).

If this PR works correctly, it should have a revised set of Travis CI checks that succeed on the 0.19.1 version of scipy with slicot not installed, but fail on all other cases.

BLD: travis update for new/old scipy + improved slycot

d4fc2d0

Copy link

coveralls commentedDec 23, 2017•
edited
Loading

Coverage decreased (-11.7%) to 65.958% when pullingd4fc2d0 on murrayrm:fix_travis into05d6bc5 on python-control:master.

Copy link

MemberAuthor

murrayrm commentedDec 23, 2017

Check completed as described above.

This was referencedDec 23, 2017

Slycot installation failing in Travis CI#168

Closed

Fixes for SciPy 1.0 compatibility#170

Merged

BLD: updated Travis CI script to build slycot from source

b6e378f

Copy link

MemberAuthor

murrayrm commentedDec 24, 2017

Update PR to include new rules for building slycot from source, which allows proper checking against the slycot version of the library. A couple of notes on the implementation:

Need to be careful about how to installgfortran andlapack. Install both viaapt-get in the root environment (not the test-environment) to make sure that compilers use the right paths (found this out the hard way, but trying almost every other combination of things).
Python3 implementations need to have theLIBRARY_PATH environment variable set up properly, otherwise slycot will fail to link properly. For this, you need to link to the version in the local environment, so that you get the right version of python.

While I was at it, I made a few other changes:

Reordered the build cases to start with the most up-to-date case (python-3.6,scipy-1.0,slycot) gets tested version.
Added more comments throughout to explain what is going on.
Don't bother to installconda-build since it is not needed any more.

Some of the Travis builds will still fail for this version since the corrections forscipy-1.0 from PR#164 are not yet included.