Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update conda-recipe for use with conda-build >= 3.0#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
murrayrm merged 1 commit intopython-control:masterfrommurrayrm:fix_conda
Jan 2, 2018

Conversation

murrayrm
Copy link
Member

This PR updates the conda recipe so that it works correctly withconda-build 3.0. The basic change is to extract the version information directly from git, using jinja commands.

This PR should run correctly using Travis CI, fixing issue#159.

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.9%) to 65.825% when pulling91d5355 on murrayrm:fix_conda into05d6bc5 on python-control:master.

@murrayrm
Copy link
MemberAuthor

Integration checks look OK. Most are failing because of issue#164 (scipy 1.0 compatibility), but otherwise running properly. There is also an unknown issue with python3.3 that seems to be related to an error while installing packagedefaults::openssl-1.0.1k-1.

@murrayrmmurrayrm mentioned this pull requestDec 23, 2017
@murrayrmmurrayrm added this to the0.8.0 milestoneDec 27, 2017
@murrayrm
Copy link
MemberAuthor

murrayrm commentedDec 28, 2017
edited
Loading

Followup comment: need to rethink this PR a bit. By removingmake_version.py, I messed up the automatic versioning that@cwrowley put into place in PR#52. Probably still need to runmake_version.py in the conda recipe, but not rely on it for the version information in conda (since__conda_version__ is not supported).

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling087046f on murrayrm:fix_conda into ** on python-control:master**.

@murrayrm
Copy link
MemberAuthor

murrayrm commentedDec 29, 2017
edited
Loading

I've updated this PR to leavemake_version.py in place, but still usejinja for generating the version information inmeta.yaml. I squashed the commits so that the history is clean. This PR will allow conda-build 3.0 to work correctly.

Travis CI checks fail due to SciPy c1.0 incompatibility. This is expected and solved by PR#170.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling087046f on murrayrm:fix_conda into ** on python-control:master**.

@roryyorke
Copy link
Contributor

FWIW, Python 3.3 is end-of-life (seehttps://devguide.python.org/#status-of-python-branches ). Are you aware of any python-control users requiring it? If not, we might as well drop it.

@murrayrm
Copy link
MemberAuthor

Travis CI testing for Python 3.3 (and 3.4) has been removed in PR#169. I don't see any need to support Python 3.3 going forward => haven't bother to debug the issue that was described above.

@murrayrmmurrayrm merged commit9457031 intopython-control:masterJan 2, 2018
@murrayrmmurrayrm deleted the fix_conda branchJanuary 2, 2018 16:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@murrayrm@coveralls@roryyorke

[8]ページ先頭

©2009-2025 Movatter.jp