- Notifications
You must be signed in to change notification settings - Fork441
Update conda-recipe for use with conda-build >= 3.0#167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedDec 23, 2017
Integration checks look OK. Most are failing because of issue#164 (scipy 1.0 compatibility), but otherwise running properly. There is also an unknown issue with python3.3 that seems to be related to an error while installing package |
murrayrm commentedDec 28, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Followup comment: need to rethink this PR a bit. By removing |
coveralls commentedDec 29, 2017
Changes Unknown when pulling087046f on murrayrm:fix_conda into ** on python-control:master**. |
murrayrm commentedDec 29, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I've updated this PR to leave Travis CI checks fail due to SciPy c1.0 incompatibility. This is expected and solved by PR#170. |
coveralls commentedDec 29, 2017
Changes Unknown when pulling087046f on murrayrm:fix_conda into ** on python-control:master**. |
FWIW, Python 3.3 is end-of-life (seehttps://devguide.python.org/#status-of-python-branches ). Are you aware of any python-control users requiring it? If not, we might as well drop it. |
Travis CI testing for Python 3.3 (and 3.4) has been removed in PR#169. I don't see any need to support Python 3.3 going forward => haven't bother to debug the issue that was described above. |
This PR updates the conda recipe so that it works correctly with
conda-build
3.0. The basic change is to extract the version information directly from git, using jinja commands.This PR should run correctly using Travis CI, fixing issue#159.