NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

SISO tf() may not work with numpy arrays with numpy.int elements.#158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

kangwonlee wants to merge4 commits intopython-control:masterfromkangwonlee:feature/test_int_tf

Closed

SISO tf() may not work with numpy arrays with numpy.int elements.#158

kangwonlee wants to merge4 commits intopython-control:masterfromkangwonlee:feature/test_int_tf

Conversation

Copy link

kangwonlee commentedOct 22, 2017

SISO tf() function may not work if an input argument is numpy.int.
(@sunhapos could identify this)

Please check the test for cases.

Should this be a numpy issue? If so, is a quick patch such as3fe4067 desirable?

Thanks,

kangwonlee added2 commits

October 23, 2017 01:14

SISO tf() may not work with numpy arrays with numpy.int elements.

facfe9c

a possible quick patch

3fe4067

Copy link

Author

kangwonlee commentedOct 22, 2017

Does this discussion seem related?numpy/numpy#2951

kangwonlee added2 commits

October 23, 2017 03:27

conda-build=2.1.17

287f825

Merge branch 'feature/conda_build_less_3.0' into feature/test_int_tf

70092cf

Copy link

coveralls commentedOct 22, 2017•
edited
Loading

Coverage increased (+0.6%) to 78.327% when pulling70092cf on autodrive:feature/test_int_tf into05d6bc5 on python-control:master.

Copy link

Contributor

roryyorke commentedOct 22, 2017

Have you looked at PR#135 ? I see @jed-frey handles all sorts of types in the proposed_cleanup functionhere

Copy link

Author

kangwonlee commentedOct 22, 2017

@roryyorke Thanks for your comments. @jed-frey Hope this helps. Also found thisQnA.

Copy link

Member

murrayrm commentedDec 27, 2017•
edited
Loading

Different parts of this PR are covered by other PR's:

PRFixes for SciPy 1.0 compatibility #170 has a fix for the originally identified issue ofnumpy.int data types. Note that the fix there is more general (handles anynumpy.number type).
PRSISO tf() may not work with numpy arrays with numpy.int elements. #158 fixes the issue with conda that was also addressed here (by using an earlier version of conda).

There is some unit test code there that it would be good to merge. I will try to take care of that in the coming days.