Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow unit tests to run without slycot#122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
slivingston merged 4 commits intopython-control:masterfrommurrayrm:noslycot
Dec 31, 2016

Conversation

murrayrm
Copy link
Member

This PR provides updates to allow unit tests to run correctly whenslycot is not installed. There is also a change inxferfcn.py to allow proper creation of transfer functions when num or den is a 0d ndarray. This can occur whenslycot is not installed due to a difference in the way that transfer functions are created from state space matrices inxferfcn._convertToTransferFunction() whenslycot is not available.

@coveralls
Copy link

coveralls commentedDec 26, 2016•
edited
Loading

Coverage Status

Changes Unknown when pullingcab850a on murrayrm:noslycot into ** on python-control:master**.

@murrayrmmurrayrm changed the titleNoslycotAllow unit tests to run without slycotDec 26, 2016
@coveralls
Copy link

coveralls commentedDec 26, 2016•
edited
Loading

Coverage Status

Changes Unknown when pullingc90a399 on murrayrm:noslycot into ** on python-control:master**.

@slivingstonslivingston self-assigned thisDec 31, 2016

# Set up a transfer function (should always work)
tfcn = control.tf([[[-235, 1.146e4],
[-235, 1.146E4],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Indentation here and on the next 4 lines seems to be slightly off. I recommend

tfcn=control.tf([[[-235,1.146e4],                            [-235,1.146E4],                            [-235,1.146E4,0]]],                          [[[1,48.78,0],                            [1,48.78,0,0],                            [0.008,1.39,48.78]]])

@coveralls
Copy link

coveralls commentedDec 31, 2016•
edited
Loading

Coverage Status

Changes Unknown when pulling7de3cc8 on murrayrm:noslycot into ** on python-control:master**.

@slivingston
Copy link
Member

For future work, I think that it would be useful to either:

  • notify the user when a test case is modified according to whetherslycot is found; or
  • separate instances of the above into uniquely named tests, so that a test case is never hot-swapped but rather skipped or not.
murrayrm reacted with thumbs up emoji

@slivingstonslivingston merged commit25747c7 intopython-control:masterDec 31, 2016
@murrayrmmurrayrm deleted the noslycot branchJanuary 5, 2017 06:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@slivingstonslivingstonslivingston left review comments

Assignees

@slivingstonslivingston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@murrayrm@coveralls@slivingston
[8]ページ先頭
©2009-2025 Movatter.jp