- Notifications
You must be signed in to change notification settings - Fork445
Robust hinfsyn: add suboptimal synth#1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Robust hinfsyn: add suboptimal synth#1184
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ilayn commentedNov 4, 2025
Note that this relaxation works typically OK with LMI based design since you introduce slackness but for Riccati based solvers there are no guarantees that this improves the conditioning of the controllers. This is typically due to the bilinear nature of the problem. It works OK for smooth-enough problems though. |
murrayrm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for this contribution,@wuschel-brompf. I had a few things that I think should be updated to be consistent with our coding conventions and to provide a bit more information to the user.
Also, we need a unit test that covers the new code.
| defhinfsyn(P,nmeas,ncon): | ||
| defhinfsyn(P,nmeas,ncon,gamTry=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This parameter name doesn't not follow python-control naming conventions. From thedeveloper notes:
Use longer description parameter names that describe the action or role (e.g., trajectory_constraints and print_summary inoptimal.solve_optimal_trajectory.
I suggest something liketarget_gamma for this parameter name.
| ncon : int | ||
| Number of control inputs (output from controller). | ||
| gamTry : int, optional | ||
| Target performance level (default = None). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Although this is consistent with the current very terse docstring, I think a bit more information is needed, either here or in a Notes section later in the docstring. Something like:
If
target_gammais specified, then a controller with the target value of$\gamma$ will be generated. This is potentially suboptimal, but save computation time.
to obtain numerically more robust controllers, usually a slightly suboptimal controller is synthesized after running the first optimization.