- Notifications
You must be signed in to change notification settings - Fork445
Use pytest markers for slycot, cvxopt, and pandas tests#1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The pytest marker slycot is equivalent to the slycotonly decorator,and also allows slycot tests to be included or excluded at the pytestcommand-line.
The pytest marker cvxopt is equivalent to the cvxoptonly decorator,and also allows cvxopt tests to be included or excluded at the pytestcommand-line.
coveralls commentedOct 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
roryyorke commentedOct 18, 2025
Is it expected that the |
bnavigator commentedOct 18, 2025
It only runs when one of the specified files in .github is changed:#821 |
roryyorke commentedNov 2, 2025
Anyone had a look at this yet? Would like to merge this so Slycot tests can be clean, and we can move ahead withpython-control/Slycot#250 . |
control/tests/conftest.py Outdated
| cvxoptonly=pytest.mark.skipif( | ||
| notcontrol.exception.cvxopt_check(),reason="cvxopt not installed") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
replace this as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks, missed that. Fixed in01d76fd
bnavigator commentedNov 2, 2025
Yes, sorry for not getting back earlier. LGTM. |
2435a6a intopython-control:mainUh oh!
There was an error while loading.Please reload this page.
Using these markers allows selection of tests at the command-line, which is useful to focus on specific test types in development, and specifically allows testing only Slycot-dependent tests in Slycot CI.