BugFix:`place_acker` output should be 2D array#1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

base:main

Choose a base branch

Open

Conversation

Copy link

Contributor

place_acker function's output is a 1D array, while it should be a 2D array as described in its doc string.

BugFix:place_acker output should be 2D matrix

37ccb27

Copy link

coverage: 94.734%. remained the same
when pulling37ccb27 on guptavaibhav0:main
intoabeb0e4 on python-control:main.

Copy link

Member

Good fix,@guptavaibhav0! Can you also update the unit test instatefbk_test.py so that it exhibits the error. On line 273, if you change

ss(sys.A - sys.B * K, sys.B, sys.C, sys.D)

to read

ss(sys.A - sys.B @ K, sys.B, sys.C, sys.D)

then the previous code will generate an error.

None yet