NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

Add support for continuous delay systems#1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

MythasNauveili wants to merge18 commits intopython-control:main

base:main

Choose a base branch

fromMythasNauveili:dev-delay

Open

Add support for continuous delay systems#1148

MythasNauveili wants to merge18 commits intopython-control:mainfromMythasNauveili:dev-delay

Conversation

Copy link

MythasNauveili commentedMay 11, 2025

This PR introduces initial support for linear time-invariant (LTI) systems with time delays inpython-control, inspired by the capabilities ofControlSystems.jl package, and theInternalDelay.py script fromSkogestad-Python.

Key features

Creation of delay sytems Systems with delays can now be intuitively constructed by multiplying aTransferFunction object with adelay(tau) object or anexp(-tau*s) expression:
```
tf_delay=tf([1], [1,1])*delay(2)# ors=tf("s")tf_delay=tf([1], [1,1])*exp(-2*s)
```
Underlying Representation: The approach utilizes Linear Fractional Transformations (LFT) with aPartitionedStateSpace representation (implemented inpartitionedssp.py). TheDelayLTI class (indelaylti.py) serves as the core object for these systems.
Operations: Standard operations such as addition, multiplication, and feedback are supported forDelayLTI objects.
Time and Frequency Responses: Time responses for delayed systems are computed by solving the underlying Delay Differential Equations (DDEs). Frequency responses are also supported.
Retrocompatibility: Maintain retrocompatibility with existing functionalities.

Implementation Details:

DDE Solver: Time responses for delayed systems are computed by solving DDEs. After exploring alternatives, a custom DDE solver based on the Method of Steps, wrapping SciPy'ssolve_ivp, was implemented indde.py.
- Accuracy Note: While this solver performs well for many cases, for stiff problems, it may require smaller step sizes for convergence compared to specialized DDE solvers (like those in ControlSystems.jl). In tested scenarios, the error typically remains at least three orders of magnitude below the system response with reasonable step sizes. (An error estimation algorithm could be a valuable future addition).
Validation: A Julia script (control/julia/compute_tests.jl) using ControlSystems.jl has been added to generate reference results, which are exported to a JSON file. These results are used in the test suite (control/tests/delay_lti_test.py andcontrol/tests/dde_test.py) to benchmark the accuracy of theDelayLTI implementation and DDE solver.

Current Scope and Limitations:

This implementation currently focuses oncontinuous-time delay systems. Discrete-time delay systems are not yet covered.
The DDE solver may benefit from further enhancements for stiff problems or adaptive step sizing.

Discussion Points:
This PR represents the initial groundwork for this feature. I'm submitting this draft to share these first steps and would appreciate feedback on:

The overall approach and class design (DelayLTI,PartitionedStateSpace).
The DDE solver implementation and its current performance.
Any potential integration issues or API considerations.

I'm aware there is still work to be done for this feature to be ready for a full release, but I believe this provides a solid foundation.

MythasNauveiliand others added15 commits

March 26, 2025 08:56

implement delayLTI and PartionedStateSpace classes and first algorith…

de5a61f

…m to solve delay ODE in timeresp. Add litlle tests about timereps

Merge branch 'python-control:main' into dev-delay

848d763

ongoing tests with julia notebooks, feedback bug solved

2c74ca1

mimo building of delay systems

b6c0cde

implementation of working frequency response for delayed siso system

8dcab54

__call__ implementation to use lti frequency response function

9b7b062

delay systems handle freq plots (julia comparison ok). Time to work o…

e8a197b

…n the DDE integration

add dde.py file to improve readibility in timeresp.py

29081b5

implemented only basic dde solving based on Skogestad python

add tests and docstrings, tests are all passing. ToDo: refine tests, …

8f43ab9

…improve doc and julia notebook. Clean the code

improve tests by scripting julia code to mimic python tests, and seri…

30c05b9

…alize with json file.Fix scalar multiplication

methods of steps implemented, 1E-5 accuracy against julia for first t…

53641f4

…ests.TODO: clean dde file, test functions in it, and reloacate dde response tests. More tests also like mimo force response are needed

Merge branch 'python-control:main' into dev-delay

b0f2cd3

cleaning old dde methods

4172ce8

mimo forced response passed. TODO: clean

a460513

docstrings, ruff check and format

f56e5de

murrayrm requested changes

May 12, 2025

View reviewed changes

Copy link

Member

murrayrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Initial round of comments. I haven't yet checked functionality, but found a few style issues that should be updated.

control/dde.py Outdated

		U = _check_convert_array(
		U, legal_shapes, "Parameter `U`: ", squeeze=False, transpose=transpose
		)
		print("U shape: ", U.shape)

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks like a debugging statement that was left in the code?

Copy link

Author

MythasNauveiliMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

removed in last commit

control/dde.py Outdated

		discontinuity_times.remove(t_stop)
		local_t_eval = [t for t in T if current_t < t <= t_stop]

		print("Integrate bewtween ", current_t, " and ", t_stop)

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Debugging statement?

Copy link

Author

MythasNauveiliMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

removed in last commit

control/__init__.py Outdated

		@@ -89,6 +89,7 @@

		# Allow access to phase_plane functions as ct.phaseplot.fcn or ct.pp.fcn
		from . import phaseplot as phaseplot

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Was there a reason to add an extraneous blank line here?

Copy link

Author

MythasNauveiliMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no, blank line is removed in the last commit

control/dde.py Outdated

		)


		def pchip_interp_u(T, U):

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks like it is probably an internal function. If so, add underscore to start of function name.

Copy link

Author

MythasNauveiliMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

underscore added

control/dde.py Outdated

		return np.array([negative_wrapper(PchipInterpolator(T, ui)) for ui in U])


		class DdeHistory:

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This might be better namedDDEHistory (since DDE is a standard abbreviation, like LTI)?

Also, if this is an internal class, begin the class name with an underscore.

Copy link

Author

MythasNauveiliMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changed the name and added the underscore

control/delaylti.py Outdated


		Notes
		-----
		The way to create a DelayLTI object is by multiplying a transfert

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Typo: transfert → transfer

control/delaylti.py Outdated

Comment on lines 99 to 100

		It's possible to MIMO delayed systems from arrays of SISO delayed systems,
		see function mimo_delay

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's possible to MIMO → It is possible to create

Also missing a period at the end.

control/delaylti.py Outdated


		# Poles and zeros functions for DelayLTI are not supported by julia ControlSystems.jl
		# might not be accurate for delayLTI, to be discussed
		# Here the poles and zeros computed are the ones of the system without taking into accoutn the delay

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Typo + may be longer than 78 char (PEP8).

control/delaylti.py Outdated

		# Check dimensions of K
		if K.shape != (self.nu, self.ny):
		raise ValueError(
		f"Feedback gain K has incompatible shape. Expected ({self.nu}, {self.ny}), got {K.shape}."

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Update to avoid line with more than 78 characters and put closing parenthesis at end of string, for consistency with current code base.

control/delaylti.py Outdated

Comment on lines 549 to 552

		def issiso(self):
		"""Check if the system is single-input, single-output."""
		# Based on EXTERNAL dimensions
		return self.nu == 1 and self.ny == 1

Copy link

Member

murrayrmMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should be handled by the parent class (InputOutputSystem).

Copy link

Author

MythasNauveiliMay 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is now moved toInputOutputSystem

Copy link

Member

murrayrm commentedMay 12, 2025

This would be a great contribution,@MythasNauveili. Thanks for working on it!

There are some issues with unit tests. In addition to the failed ruff and doctest checks, it looks like some of the standard tests might be hanging. Not sure if that is due to the new code or if something is messed up in the GitHub actions. I'll try to come back and take a look at that later.

In the meantime, some style things to adjust in your next pass.

MythasNauveili added2 commits

May 12, 2025 20:36

improve formatting, underscore internal functions, add file description

36ad284

implement delay case in input_output_response, move and test issiso f…

4870463

…or delayLTI to iosys.py

Copy link

Author

MythasNauveili commentedMay 12, 2025

Thanks for the first feedback@murrayrm. I tried to fix the most in the two last commits. For the tests hanging, it might be because of debug plots that I did not disable indde_test.py (this should be done now).

Copy link

coveralls commentedMay 12, 2025•
edited
Loading

coverage: 94.16% (-0.6%) from 94.746%
when pulling1150646 on MythasNauveili:dev-delay
into632391c on python-control:main.

Copy link

Member

murrayrm commentedMay 13, 2025

@MythasNauveili There are still two unit tests failing. Click on the links above to see the issues. The ruff checks should be straightforward. For the doctest, it looks like something is printing out spurious information; not sure where that is happening.

remove forgotten debug print in timeresp, and unused imports in delay…

1150646

…_test

Copy link

Author

MythasNauveili commentedMay 13, 2025

@murrayrm it might be ok now, I just removed a forgotten debug print intimeresp.py that was the source of thedxdt = [...]

MythasNauveili marked this pull request as ready for review

June 19, 2025 08:20

Labels

None yet

3 participants

Movatterモバイル変換

Add support for continuous delay systems#1148

Are you sure you want to change the base?

Add support for continuous delay systems#1148

Uh oh!

Conversation

MythasNauveili commentedMay 11, 2025

Uh oh!

murrayrm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

murrayrm commentedMay 12, 2025

Uh oh!

MythasNauveili commentedMay 12, 2025

Uh oh!

coveralls commentedMay 12, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

murrayrm commentedMay 13, 2025

Uh oh!

MythasNauveili commentedMay 13, 2025

Uh oh!

Uh oh!

coveralls commentedMay 12, 2025•
edited
Loading