Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix CI doctest, install-examples#1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

roryyorke
Copy link
Contributor

Fixesgh-1136.

I tried '!=8.2' for sphinx-doc, which didn't work, so I used '<8.2'. I think '!=8.2.*' might, but didn't try it. Seehttps://packaging.python.org/en/latest/specifications/version-specifiers/#id5 (not sure this applies to Conda/Mamba - it should).

@coveralls
Copy link

Coverage Status

coverage: 94.744%. remained the same
when pulling2eab304 on roryyorke:fix-ci-doctest-install-examples
intof6799ab on python-control:main.

@murrayrm
Copy link
Member

It would be nice to block out just the version that is failing, if possible, so that we will test against the latest new release when it comes out (and hopefully the bug is fixed).

Also, should we put something inpyproject.toml to flag this issue? If not, then a user could install with the latest version of iPython (or sphinx) and things might not work. I'm not quite sure where that would go, since python-control is notdependent on iPython.

@roryyorke
Copy link
ContributorAuthor

For IPython, it's reasonably likely that an upcoming release, say 9.0.1, will fix this (ipython/ipython#14807 claims to fix it). If it's later, 9.0.2 or whatever, we can update the relevant config file(s) to exclude all the broken version. So here I think the CI fix is OK.

For sphinx, the situation is trickier. Fromsphinx-doc/sphinx#13364 andsphinx-doc/sphinx#13352 , sphinx have made a change that breaks nbsphinx, and nbsphinx has a PR for necessary updates atspatialaudio/nbsphinx#826, but it's not clear when that will be merged and released.

I don't think there's a way to say "use nbsphinx >= 0.9.7, or failing that, use sphinx < 8.2.*", so I think the sphinx version condition I've added is a stop-gap until there's a released nbsphinx fix. I know this sort of stop-gap can easily last months (or years), and I don't know what to do about that. I guess a TODO in thedoctest-env.yml, and open an issue now.

I've pushed a prototype ofsphinx!=8.2.*, seehttps://github.com/roryyorke/python-control/actions/runs/13617760094/job/38063032976 , but I now think it's just as much of a stop-gap as<8.2.

As for pyproject.toml: I don't know if we can or should do anything about IPython. It's a clear bug (install IPython, runload_ext autoreload, and it's triggered) that doesn't affect only control-python, and that should be fixed soon(ish). The same reasoning applies to sphinx and nbsphinx, but in addition I imagine non-dev users rarely install these.

murrayrm reacted with thumbs up emoji

@murrayrm
Copy link
Member

Thanks@roryyorke for the detail comments and the fix. I'll let this sit for a bit (at least rest of the day) before merging, in case others have comments. But I think this is otherwise good to go (and we need to get something in place soon to fix the CI tests for current and upcoming PRs).

@murrayrmmurrayrm merged commit58e7ad9 intopython-control:mainMar 3, 2025
24 checks passed
@murrayrmmurrayrm added this to the0.10.2 milestoneMar 3, 2025
@Carreau
Copy link

IPython 9.0.1 should be out.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.2
Development

Successfully merging this pull request may close these issues.

CI failures in doctest, examples
4 participants
@roryyorke@coveralls@murrayrm@Carreau

[8]ページ先頭

©2009-2025 Movatter.jp