Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

CI: explicitly include defaults channel#1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@slivingston
Copy link
Member

This change is motivated by that of commit814f414 (from PR#1128)

slivingston added a commit to slivingston/Slycot that referenced this pull requestFeb 17, 2025
@coveralls
Copy link

coveralls commentedFeb 17, 2025
edited
Loading

Coverage Status

coverage: 94.744%. remained the same
when pulling6c628f0 on slivingston:ci-add-defaults-miniforge
into061749d on python-control:main.

This change is motivated by that of commit814f414
slivingston added a commit to slivingston/Slycot that referenced this pull requestFeb 17, 2025
@murrayrm
Copy link
Member

murrayrm commentedFeb 17, 2025
edited
Loading

@slivingston Despite the claim that all checks completed, in fact the conda-based tests did not complete. SeeOS/BLAS test matrix run. It looks like the conda test matrix gets created but does not run.

The error is

Error when evaluating 'strategy' for job 'test-conda'. .github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): Error parsing fromJson,.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): Unexpected value ''

???

@slivingston
Copy link
MemberAuthor

@slivingston Despite the claim that all checks completed, in fact the conda-based tests did not complete. SeeOS/BLAS test matrix run. It looks like the conda test matrix gets created but does not run.

The error is

Error when evaluating 'strategy' for job 'test-conda'. .github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): Error parsing fromJson,.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/os-blas-test-matrix.yml (Line: 277, Col: 15): Unexpected value ''

???

Good catch. Yes, I am investigating this and a similar change for Slycot on which I am working.

@slivingstonslivingston marked this pull request as draftFebruary 17, 2025 04:26
@slivingston
Copy link
MemberAuthor

It looks like the same hidden error happened 2 weeks ago in a different PR:https://github.com/python-control/python-control/actions/runs/13107250760

@slivingstonslivingston marked this pull request as ready for reviewFebruary 17, 2025 07:46
@slivingston
Copy link
MemberAuthor

Commit1ceeeea deleted required imports ina test matrix generation script, resulting in an uncaught exception. The backtrace from Python would then be used as the saved output in astep of the workflow file. One of the next jobs tries to parse this output as JSON, hence the error from JsonReader. This is treated as a syntax error in the workflow file, thus an incomplete rather than a failed job.

I modified the workflow files so that errors from the test matrix generation scripts surface clearly as failed jobs.

@slivingstonslivingston marked this pull request as draftFebruary 17, 2025 08:03
@slivingston
Copy link
MemberAuthor

...actually, still debugging. I will finish it in the morning.

@slivingstonslivingston marked this pull request as ready for reviewFebruary 17, 2025 19:36
@slivingston
Copy link
MemberAuthor

This is ready for review.

@bnavigator
Copy link
Contributor

Sorry for the extra delete in1ceeeea

@murrayrmmurrayrm merged commitd11f05d intopython-control:mainFeb 17, 2025
68 checks passed
@slivingston
Copy link
MemberAuthor

Sorry for the extra delete

@bnavigator No worries! I only intended to find the origin, not accuse anyone.

bnavigator reacted with thumbs up emoji

@slivingstonslivingston deleted the ci-add-defaults-miniforge branchFebruary 17, 2025 23:18
@murrayrmmurrayrm added this to the0.10.2 milestoneFeb 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bnavigatorbnavigatorbnavigator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

4 participants

@slivingston@coveralls@murrayrm@bnavigator

[8]ページ先頭

©2009-2025 Movatter.jp