- Notifications
You must be signed in to change notification settings - Fork446
CI: explicitly include defaults channel#1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
CI: explicitly include defaults channel#1129
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedFeb 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This change is motivated by that of commit814f414
7499bd5 to3079721Comparemurrayrm commentedFeb 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@slivingston Despite the claim that all checks completed, in fact the conda-based tests did not complete. SeeOS/BLAS test matrix run. It looks like the conda test matrix gets created but does not run. The error is ??? |
slivingston commentedFeb 17, 2025
Good catch. Yes, I am investigating this and a similar change for Slycot on which I am working. |
slivingston commentedFeb 17, 2025
It looks like the same hidden error happened 2 weeks ago in a different PR:https://github.com/python-control/python-control/actions/runs/13107250760 |
8f33d82 to9b228b1Compareslivingston commentedFeb 17, 2025
Commit1ceeeea deleted required imports ina test matrix generation script, resulting in an uncaught exception. The backtrace from Python would then be used as the saved output in astep of the workflow file. One of the next jobs tries to parse this output as JSON, hence the error from JsonReader. This is treated as a syntax error in the workflow file, thus an incomplete rather than a failed job. I modified the workflow files so that errors from the test matrix generation scripts surface clearly as failed jobs. |
7d4a01f tobaaae00Compareslivingston commentedFeb 17, 2025
...actually, still debugging. I will finish it in the morning. |
baaae00 to04d729eCompare04d729e to6c628f0Compareslivingston commentedFeb 17, 2025
This is ready for review. |
bnavigator commentedFeb 17, 2025
Sorry for the extra delete in1ceeeea |
d11f05d intopython-control:mainUh oh!
There was an error while loading.Please reload this page.
slivingston commentedFeb 17, 2025
@bnavigator No worries! I only intended to find the origin, not accuse anyone. |
This change is motivated by that of commit814f414 (from PR#1128)