- Notifications
You must be signed in to change notification settings - Fork445
Fix missing plot title in bode_plot() with display_margins#1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
murrayrm merged 1 commit intopython-control:mainfrommurrayrm:fix_bode_margins_title-02Feb2025Feb 3, 2025
Merged
Fix missing plot title in bode_plot() with display_margins#1121
murrayrm merged 1 commit intopython-control:mainfrommurrayrm:fix_bode_margins_title-02Feb2025Feb 3, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coveralls commentedFeb 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
slivingston approved these changesFeb 3, 2025
f73e893 intopython-control:main 24 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to fix a bug where setting
display_margins=Trueinbode_plot()caused the title to disappear. The bug was caused by overwriting theaxvariable...Also added logic to allow the grid to be turned back on (it defaults to off if
display_marginsis True).Unit tests included that catches the previous bug and verifies new functionality.