On Mon, 20 Jan 2025, 05:20 Scott C. Livingston, ***@***.***> wrote: ***@***.**** approved this pull request. Code is correct. I found a misprint in the test comments. If I simply misinterpreted the comment, feel free to merge. ------------------------------ In control/tests/statefbk_test.py <#1099 (comment)> : > @@ -79,6 +96,23 @@ def testObsvT(self): Wo = obsv(A, C, t=t) np.testing.assert_array_almost_equal(Wo, Wotrue) + def testObsvNdim1(self): + #gh-1097: treat 1-dim C as 1xn + A = np.array([[1., 2.], [3., 4.]]) + C = np.array([5., 7.]) + Wotrue = np.array([[5., 7.], [26., 38.]]) + Wo = obsv(A, C) + np.testing.assert_array_almost_equal(Wo, Wotrue) + + def testObsvRejectMismatch(self): + #gh-1097: check A, B for compatible shapes ⬇️ Suggested change - #gh-1097: check A, B for compatible shapes + #gh-1097: check A, C for compatible shapes — Reply to this email directly, view it on GitHub <#1099 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA3C7QM7AIWRRKUS62XJE32LRTQHAVCNFSM6AAAAABVOMBZOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRRGIZTMMRXHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>