Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow minreal to work with static gain StateSpace objects#108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

roryyorke
Copy link
Contributor

Finding this bug is what provoked#107, which this builds on.

This takes the simple option of doing nothing for a static gain. I didn't investigate the slycot.tb01pd call at all; perhaps it can take a static gain, and there's some other bug lurking in minreal code.

…ects.Allows StateSpace([],[],[],D), which failed previously.  Static gainshave sizes enforced as follows: A 0-by-0, B 0-by-ninputs, Cnoutputs-by-0.Tests added for instantiation, and sum, product, feedback, and appending,of 1x1, 2x3, and 3x2 static gains StateSpace objects.
On Python 2.7, the special case "all states useless" in_remove_useless_states resulted in A=[[0]] (and similarly for B and C).The special case is no longer needed, since empty A, B, C matrices canbe handled.  numpy.delete does the right thing w.r.t. matrixsizes (e.g., deleting all columns of a nxm matrix gives an nx0 matrix).Added test for this.
Do this by only calling Slycot's tb01pd for non-static systems.
@coveralls
Copy link

coveralls commentedAug 12, 2016
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 76.065% when pullingfb1e905 on roryyorke:ry-ss-static-minreal intod0528fd on python-control:master.

@slivingston
Copy link
Member

Pull request#110 subsumes this one.

@roryyorkeroryyorke deleted the ry-ss-static-minreal branchJanuary 5, 2019 05:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@slivingstonslivingston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@roryyorke@coveralls@slivingston

[8]ページ先頭

©2009-2025 Movatter.jp