Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix issue with multiplying MIMO LTI system by scalar#1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@murrayrm
Copy link
Member

@murrayrmmurrayrm commentedDec 7, 2024
edited
Loading

This PR addresses#1075 and also fixes a small bug with constant FRD systems with small numbers of frequency points.

Changes:

  • Multiplying (*), adding (+), or subtracting (-) a constant from any (MIMO) LTI object now acts element-wise (same as ndarray's). This fixes a bug where multiplying a MIMO LTI system by a constant was multiplying by a matrix filled with the constant rather than a diagonal matrix (scaled identity).
  • Specifying an FRD system with fewer than 4 frequency points was generating an error because the default settings try to set up a smooth (interpolating) response and the default degree of the fit was 3. The SciPy interpolation function requires k+1 data points for a degree k fit, so an exception was generated.
  • Added unit tests that catch the bug inMultiplying a MIMOTransferFunction by1.0 multiplies by a matrix of ones, not identity #1075 but also check across all LTI system representations (frd, ss, tf).

@coveralls
Copy link

coveralls commentedDec 7, 2024
edited
Loading

Coverage Status

coverage: 94.73% (+0.009%) from 94.721%
when pulling3165881 on murrayrm:fix_scalar_tfops-06Dec2024
into12dda4e on python-control:main.

@slivingstonslivingston self-requested a reviewDecember 8, 2024 17:07
@slivingstonslivingston merged commit8b6d041 intopython-control:mainDec 11, 2024
12 checks passed
@murrayrmmurrayrm added this to the0.10.2 milestoneFeb 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@slivingstonslivingstonslivingston left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

Multiplying a MIMOTransferFunction by1.0 multiplies by a matrix of ones, not identity

3 participants

@murrayrm@coveralls@slivingston

[8]ページ先頭

©2009-2025 Movatter.jp