- Notifications
You must be signed in to change notification settings - Fork445
sort loci in PoleZeroData#1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedDec 2, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
control/pzmap.py Outdated
| System name. | ||
| sys : StateSpace or TransferFunction | ||
| System corresponding to the data. | ||
| sort_loci : bool, optional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| sort_loci :bool,optional) | |
| sort_loci :bool,optional |
slivingston left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is a small misprint in the docstring. Besides that, this is ready to merge.
Not related to code: the PR description refers to Example 6.8 but links toExample 5.17. This PR is clearly relevant to Example 5.17, so I guess "Example 6.8" is a misprint or perhaps example numbers changed in the book, but I want to bring attention to it in case it indicates that more actions are necessary.
69efbbe intopython-control:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This small PR adds the option to sort loci when creating a PoleZeroData object. This is useful if you create a PoleZeroData object in some way other than calling
root_locus_map(which sorts the data ahead of time).The need for this functionality came up when working through Example 5.17 of FBS2e (bicycle eigenvalue location versus speed), as shown in the following code:
https://github.com/murrayrm/fbs2e-python/blob/main/example-5.17-bicycle_stability.py
(At some point I would like to generalized the root locus capability to allow plotting an eigenvalue locus diagram against any free parameter in a nonlinear system, but that will take more time and effort.)