Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

UnSkipTest: these tests pass on Python 2.7, 3.3, 3.4, and 3.5.#105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

roryyorke
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commentedAug 10, 2016•
edited
Loading

Coverage Status

Coverage remained the same at 76.004% when pulling6738215 on roryyorke:rory-unskip-tf-tests intod0528fd on python-control:master.

@slivingston
Copy link
Member

Does anyone know why these were being skipped originally? Theunittest.skip decorators were introduced in6d9da6e, which was a big commit that mixes many different kinds of changes, and the commit message does not offer relevant explanation.

@slivingston
Copy link
Member

Otherwise, I agree with the changes and will merge after some comment about the original motivation is made.

Perhaps@jgoppert knows.

@murrayrm
Copy link
Member

I took a quick look and couldn't see any reason why these were skipped.

@slivingstonslivingston merged commit6738215 intopython-control:masterAug 14, 2016
slivingston added a commit that referenced this pull requestAug 14, 2016
title: "UnSkipTest: these tests pass on Python 2.7, 3.3, 3.4, and 3.5"#105
@slivingston
Copy link
Member

Before merging this, I found that all tests pass on a Debian GNU/Linux x86_64 box with Python versions 2.7.9, 3.3.6, 3.4.2, 3.5.2

@murrayrmmurrayrm modified the milestone:0.8.0Dec 27, 2017
@murrayrm
Copy link
Member

Decided not to track this against milestone 0.8.0 since it is primarily an internal change (so not visible to users).

@roryyorkeroryyorke deleted the rory-unskip-tf-tests branchDecember 29, 2017 08:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@slivingstonslivingston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@roryyorke@coveralls@slivingston@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp