- Notifications
You must be signed in to change notification settings - Fork441
Update shared axes processing in plot_time_response#1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedAug 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
control/freqplot.py Outdated
| will force the legacy values (mag, phase, omega) to be returned | ||
| (with a warning). To obtain just the frequency response of a system | ||
| (or list of systems) without plotting, use the | ||
| 1. Starting with python-control version 0.10, `bode_plot`returns a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| 1.Startingwithpython-controlversion0.10,`bode_plot`returnsa | |
| 1.Startingwithpython-controlversion0.10,`bode_plot`returnsa |
This space is important because without it, Sphinx fails to parse the:class: expression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
After fixing this, the PR is ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You may want to commit the figures in the documentation that are affected by this PR.
3e9a39e intopython-control:mainUh oh!
There was an error while loading.Please reload this page.
This PR updates the way that tickmarks are labeled on shared axes in time response plots, in response to a comment from@slivingston in#1034. Tickmark labels are now omitted on shared axes, consistent with frequency response plots.
To allow tickmark labels to be added, two new keyword arguments are included in
time_response_plot:sharexandsharey. These are passthrough arguments tomatplotlib.pyplot.subplotsand allow axes sharing to be turned on and off in the same way asbode_plot=> frequency and time response plots are now consistent.Also added unit tests checking for consistency and updated the user documentation and relevant docstrings.
sharex=False):