- Notifications
You must be signed in to change notification settings - Fork441
Move ctrlplot code prior to upcoming PR#1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Move ctrlplot code prior to upcoming PR#1033
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedJul 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
control/ctrlplot.py Outdated
| @@ -89,6 +112,125 @@ def get_plot_axes(line_array): | |||
| # | |||
| # Utility functions | |||
| # | |||
| # These functions are used by plotting routines to provide a consistent way | |||
| # of processing and displaing information. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| # of processing anddisplaing information. | |
| # of processing anddisplaying information. |
1a276dc intopython-control:mainUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me.
This PR moves around some functions from
freqplot.pyandtimeplot.pytoctrlplot.pyin preparation for an upcoming PR that is going to modify those functions. There is no change in functionality, but I want people to be able to see the changes I am making to functions inctrlplot.pyin the upcoming PR => need to move things around first so thatgit diffcan highlight the changes.Summary of changes:
rcParamsdict used to customize plotting functions is now inctrlplot.py(instead of having two separate but identicalrcParamsinfreqplot.pyandtimpelot.py)._process_ax_keywordutility function is now inctrlplot.py(instead offreqplot.py)._process_line_labelsutility function is now inctrlplot.py(instead offreqplot.py)._get_line_labelsutility function is now inctrlplot.py(instead offreqplot.py)._add_arrows_to_line2Dutility function is now inctrlplot.py(instead offreqplot.py).grid.py.