NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

Add function to convert a system into observable canonical form#103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

murrayrm merged 1 commit intopython-control:masterfromyuina822:observable_form

Nov 18, 2016

Merged

Add function to convert a system into observable canonical form#103

murrayrm merged 1 commit intopython-control:masterfromyuina822:observable_form

Nov 18, 2016

Conversation

Copy link

Contributor

yuina822 commentedAug 7, 2016

Only for SISO systems

Add function to convert a system into observable canonical form

98e71cb

Copy link

coveralls commentedAug 7, 2016•
edited
Loading

Coverage decreased (-0.5%) to 75.546% when pulling06891be on yuina822:observable_form into7b07af3 on python-control:master.

Copy link

Member

murrayrm commentedAug 7, 2016

Can we put in some unit tests to confirm that this is working. (And while we are at it, perhaps add some unit tests for reachable canonical form?)

Also, there seems to be a a problem with the python 3.3 build (looks like a conda problem/version conflict) that we should sort out.

Copy link

Contributor

mp4096 commentedAug 7, 2016

I actually added two tests for the reachable canonical form in#101, seehere. One can easily adapt them for the OCF.

Copy link

ContributorAuthor

yuina822 commentedAug 16, 2016•
edited
Loading

I have write a observable test unit5f6139c. Thank you@mp4096 . Unobservable test didn't done well because exception handling for unobservable systems isn't added. I think we could add exception handling for unreachable/unobservable systems incanonical.py.