- Notifications
You must be signed in to change notification settings - Fork441
Fix incorrect attribute name incontrol.combine_time_responses function#1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
control.combine_time_responses functioncontrol.combine_time_responses functioncontrol.combine_time_responses functioncoveralls commentedJul 10, 2024
@diemilio Thanks! Can you add a regression test that demonstrates the bug? |
Not quite sure what happened, but I didn't mean to close this... I added a regression test. Need to figure out how to retrieve it (apologies@diemilio!). |
Merged
No problem. Sorry I could not get to add the tests earlier, so thanks for adding this. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#1025 by renaming the incorrectly used
typesattribute ofTimeResponseDataobjects totrace_types