NotificationsYou must be signed in to change notification settings
Fork441
Star1.8k

Fix impuse response, input data only contains one input[0]==1 in each trace#1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

murrayrm merged 2 commits intopython-control:mainfromKybernetikJo:fix_impulse_response

Jul 7, 2024

Merged

Fix impuse response, input data only contains one input[0]==1 in each trace#1023

murrayrm merged 2 commits intopython-control:mainfromKybernetikJo:fix_impulse_response

Jul 7, 2024

Conversation

Copy link

Contributor

KybernetikJo commentedJul 3, 2024

Computation of impulse response was correct, but input in impulse response was not.

Fix impuse response, input data only contains one inpute[0]==1 in eac…

a03ed38

…h trace

Copy link

coveralls commentedJul 3, 2024

coverage: 94.533%. remained the same
when pullinga03ed38 on KybernetikJo:fix_impulse_response
into4acc78b on python-control:main.

KybernetikJo changed the title~~Fix impuse response, input data only contains one inpute[0]==1 in each trace~~Fix impuse response, input data only contains one input[0]==1 in each trace

Jul 3, 2024

Copy link

Member

slivingston commentedJul 3, 2024

@KybernetikJo Can you add a regression test that demonstrates the error you are fixing?

Add regression test for discrete impulse response input

7624aeb

Copy link

ContributorAuthor

KybernetikJo commentedJul 4, 2024

importnumpyasnpimportcontrolasctprint(ct.__version__)A= [[.5,0.25],[.0,.5]]B= [[1.,0,],[0.,1.]]C= [[1.,0.],[0.,1.]]D= [[0.,0.],[0.,0.]]dt=Truesysd=ct.ss(A,B,C,D,dt=dt)response=ct.impulse_response(sysd,T=dt*3)U=np.zeros((2,2,4),dtype=float).astype(object)U[0,0,0]=1./dtU[1,1,0]=1./dtprint(np.array_equal(response.inputs,U))display(U)display(response.inputs)

Expected / New behavior

0.10.1.dev76+g4acc78b.d20240703Truearray([[[1.0, 0.0, 0.0, 0.0],        [0.0, 0.0, 0.0, 0.0]],       [[0.0, 0.0, 0.0, 0.0],        [1.0, 0.0, 0.0, 0.0]]], dtype=object)array([[[1.0, 0.0, 0.0, 0.0],        [0.0, 0.0, 0.0, 0.0]],       [[0.0, 0.0, 0.0, 0.0],        [1.0, 0.0, 0.0, 0.0]]], dtype=object)

Old behavior

0.10.0Falsearray([[[1.0, 0.0, 0.0, 0.0],        [0.0, 0.0, 0.0, 0.0]],       [[0.0, 0.0, 0.0, 0.0],        [1.0, 0.0, 0.0, 0.0]]], dtype=object)array([[[1.0, 0.0, 0.0, 0.0],        [1.0, 0.0, 0.0, 0.0]],       [[1.0, 0.0, 0.0, 0.0],        [1.0, 0.0, 0.0, 0.0]]], dtype=object)