- Notifications
You must be signed in to change notification settings - Fork441
BuildFix: change Travis build to handle conda changes#102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
slivingston merged 1 commit intopython-control:masterfromroryyorke:rory-conda-build-tweaksAug 10, 2016
Merged
BuildFix: change Travis build to handle conda changes#102
slivingston merged 1 commit intopython-control:masterfromroryyorke:rory-conda-build-tweaksAug 10, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Changes: - do build and test inside a conda environment - specify Python version at conda build stageThese changes triggered by builds failing *without* changes occuring toHEAD.
coveralls commentedJul 6, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
mp4096 added a commit to mp4096/python-control that referenced this pull requestJul 6, 2016
Many thanks for the repaired CI config! Works like a charm for#101:https://travis-ci.org/mp4096/python-control/builds/142872267 I would actually suggest you add Python 3.5 as a fourth test environment, it seems to gain momentum steadily... |
I will review this today. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
These changes triggered by builds failingwithout changes in HEAD; I assume this is due to Conda changes, rather than Travis changes.
Seehttps://travis-ci.org/roryyorke/python-control/builds/142789873 for an example of master HEAD failing; first noticed in the Python 3.3 travis failure in#101 (haven't tested that on top of this fix, but given that it passes on Python 2.7 and 3.4, it seems like it would pass).
Both .travis.yml and conda-recipe/meta-yaml could do with a review by an expert (I'm not one); e.g., why is "nose" a build requirement, rather than a test requirement? Shouldn't we follow standard (0.7.1+stuff) versioning? Why does the version end up as 0.6d.stuff on my Travis builds, not 0.7.stuff?