Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Some minor code edits to be pulled—quick help wanted#642

billtubbs started this conversation inGeneral
Discussion options

I had some time so I made some edits to my fork of the code—mainly typos and doctoring edits and a fix to the plot legends in the cruise control example.

I haven't done this for a while so I'm not sure how to interpret these errors when I ranpytest:

=========================== short test summary info ============================SKIPPED [1] control/tests/matlab2_test.py:204: skipping test_check_convert_shape, need to update testSKIPPED [1] control/tests/matlab2_test.py:275: need to update testSKIPPED [4] control/tests/timeresp_test.py:419: test system does not settleSKIPPED [6] control/tests/timeresp_test.py:876: No continuous forced_response without time vector.SKIPPED [1] control/tests/type_conversion_test.py:162: future test; conversions not yet fully implementedSKIPPED [2] control/tests/xferfcn_test.py:742: .__matmul__ not implementedXFAIL control/tests/lti_test.py::TestLTI::test_timebaseEqual_deprecated[None-True-True]  returns falseXFAIL control/tests/optimal_test.py::test_discrete_lqr  reason: discrete LQR not implementedXFAIL control/tests/statefbk_test.py::TestStatefbk::testLQR_warning  warning not implemented============ 2740 passed, 15 skipped, 3 xfailed in 93.12s (0:01:33) ============

Could anyone help me figure this out and also help me get ready for a pull request?

You must be logged in to vote

Replies: 2 comments 1 reply

Comment options

XFAILS are "expected" failures, mainly pointing out spots where we know we are missing a feature but wanted to document that there should (eventually) be a test. So the output from your pytest run is all good.

You must be logged in to vote
1 reply
@billtubbs
Comment options

Ah, thanks for clarifying. I will submit a pull request shortly. Found a few more typos...

Comment options

This can be closed now, thanks.

You must be logged in to vote
0 replies
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Category
General
Labels
None yet
2 participants
@billtubbs@murrayrm
[8]ページ先頭
©2009-2025 Movatter.jp