Commitf7d18f1

authored

Merge pull request#912 from murrayrm/bdshur_bug-09Jun2023

fix bdschur (see issue#911)

2 parents56b9402 +d153aed commitf7d18f1Copy full SHA for f7d18f1

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -450,9 +450,7 @@ def bdschur(a, condmax=None, sort=None):`
`450`	`450`	`aschur,tschur,condmax)`
`451`	`451`
`452`	`452`	`ifsortin ('continuous','discrete'):`
`453`		`-`
`454`	`453`	`idxs=np.cumsum(np.hstack([0,blksizes[:-1]]))`
`455`		`-`
`456`	`454`	`ev_per_blk= [complex(eigvals[i].real,abs(eigvals[i].imag))`
`457`	`455`	`foriinidxs]`
`458`	`456`
`@@ -470,7 +468,7 @@ def bdschur(a, condmax=None, sort=None):`
`470`	`468`	`permidx=np.hstack([blkidxs[i]foriinsortidx])`
`471`	`469`	`rperm=np.eye(amodal.shape[0])[permidx]`
`472`	`470`
`473`		`-tmodal=tmodal @rperm`
	`471`	`+tmodal=tmodal @rperm.T`
`474`	`472`	`amodal=rperm @amodal @rperm.T`
`475`	`473`	`blksizes=blksizes[sortidx]`
`476`	`474`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -287,6 +287,8 @@ def test_bdschur_sort(eigvals, sorted_blk_eigvals, sort):`
`287`	`287`
`288`	`288`	`b,t,blksizes=bdschur(a,sort=sort)`
`289`	`289`	`assertlen(blksizes)==len(sorted_blk_eigvals)`
	`290`	`+np.testing.assert_allclose(a,t @b @t.T)`
	`291`	`+np.testing.assert_allclose(t.T,np.linalg.inv(t))`
`290`	`292`
`291`	`293`	`blocks=extract_bdiag(b,blksizes)`
`292`	`294`	`forblock,blk_eigvalinzip(blocks,sorted_blk_eigvals):`

Comments

(0)