- Notifications
You must be signed in to change notification settings - Fork71
Find module path at runtime#89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Currently, this test only passes if you run the test while being in thesource repository. Trying to run the test after installing the generatedwheel package in a different directory will fail because "./constraint" maynot exist, or worse, give a false failure since the shared librariesmight exist in the wheel package but not in the source directory.
coveralls commentedFeb 2, 2025
5a42848 intopython-constraint:mainUh oh!
There was an error while loading.Please reload this page.
fjwillemsen commentedFeb 8, 2025
@iyanmv thank you for contributing another fix! It will be included in the next release. If you need it sooner than that, let me know and I'll release an intermediate version. |
iyanmv commentedFeb 8, 2025
No, no need for an early release ;) |
fjwillemsen commentedFeb 11, 2025
I've just released this in2.0.3. Thank you again! |
Currently,
test_if_compiled()only passes if you run the test while being in the source repository. Trying to run the test after installing the generated wheel package in a different directory will fail because "./constraint" may not exist, or worse, give a false failure since the shared libraries might exist in the wheel package but not in the source directory.Instead, let's get the get the path of
constraintat runtime so that the test can be run in both scenarios.(I'm not sure if this will work as-it-is with current GitHub Actions, so opening this PR to figure it out)