Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Distribute first points in a BalancingLearner#160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
basnijholt merged 16 commits intomasterfromdistribute_points
Mar 17, 2019

Conversation

@basnijholt
Copy link
Member

Thisfixes#159.

@akhmerov could you take a look at this?

@basnijholtbasnijholt changed the titleDistribute pointsDistribute first points in a BalancingLearnerMar 16, 2019
@akhmerov
Copy link
Contributor

This fix seems to be only partial: consider for example the case when one learner is much cheaper than all the others. Then as soon as one point arrives, the balancing learner will request all points from another random learner in the queue.

If I understand correctly, an empty learner has both an infinite loss and an infinite loss improvement, however some non-empty learners also have the same loss and loss improvement. In that case the problem would arise as well.

Therefore it seems to suggest that a better fix would be to sort on(-loss, n_points) (or loss improvement, depending on the balancing learner setting).

@basnijholt
Copy link
MemberAuthor

@akhmerov, good suggestion!

I've done this in6e172ef. This is what you meant right?

I'll also do it in_ask_and_tell_based_on_loss.

@akhmerov
Copy link
Contributor

My problem right now is that the logic is rather nontrivial, and it's hard to follow especially due to very similar variable names. Comments might also help.

@basnijholtbasnijholtforce-pushed thedistribute_points branch 3 times, most recently from8025f97 to49e73f7CompareMarch 17, 2019 10:43
@basnijholt
Copy link
MemberAuthor

I found another issue that I fixed.

I've simplified it now and I think the code is understandable, do you agree?

Copy link
Contributor

@akhmerovakhmerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@basnijholtbasnijholt merged commit04e7e97 intomasterMar 17, 2019
@basnijholtbasnijholt deleted the distribute_points branchMarch 17, 2019 16:58
@basnijholtbasnijholt mentioned this pull requestMar 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@akhmerovakhmerovakhmerov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BalancingLearner puts all points in the first child-learner when asking for points with no data present

3 participants

@basnijholt@akhmerov

[8]ページ先頭

©2009-2025 Movatter.jp