Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork131
Fix doctest for get_protocol_members#680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix doctest for get_protocol_members#680
Conversation
codecovbot commentedSep 13, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@## main #680 +/- ##======================================= Coverage 97.36% 97.37% ======================================= Files 3 3 Lines 7680 7684 +4 =======================================+ Hits 7478 7482 +4 Misses 202 202
Flags with carried forward coverage won't be shown.Click here to find out more.
🚀 New features to boost your workflow:
|
AlexWaygood commentedSep 13, 2025
Cpython runs these doctests in CI but I'm not sure we do — might be worth it for us to do the same? |
JanEricNitschke commentedSep 13, 2025
Done |
Uh oh!
There was an error while loading.Please reload this page.
64a6cad intopython:mainUh oh!
There was an error while loading.Please reload this page.
Dicovered by running Cpython 3.12 test_typing.py on typing_extensions:https://github.com/JanEricNitschke/typing_extensions/actions/runs/17693805118/job/50290793287#step:7:115
"New" doctest from here:https://github.com/python/cpython/blob/805e3368d6d07e58430654d1365283924fdf4143/Lib/typing.py#L3737