Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add some miscellaneous tests#659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 13 commits intopython:mainfrombrianschubert:test-coverage
Aug 30, 2025

Conversation

@brianschubert
Copy link
Contributor

Add tests to exercise some previously unexercised lines:

  • _SpecialGenericAlias.__setattr__() for non-dunder, non-"allowed" attributes (src)
  • Wrong number of type arguments given to a_SpecialGenericAlias from without defaults (src)
  • Attempting to specialize a_SpecialGenericAlias with 0 type parameters (src)
  • Setting<thing>.__module__ on Python implementations that don't supplysys._getframemodulename orsys._getframe (src)
  • Callingget_type_hints() withtypes.GenericAlias (src)
  • Exception raised by__init_subclass__() ofParamSpec (src)
  • The methods__or__() and__ror__() of_SpecialForm (src)
  • The methods__repr__ and__reduce__ ofNoExtraItems (test case copied fromNoDefaultTests) (src)

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice, thank you!

@brianschubert
Copy link
ContributorAuthor

Thanks for the review! I pushed a few changes. re: makingParamSpec.__init_subclass__ raise in the 3.9 implementation, would this be worth a changelog mention? For reference, the 3.10+ implementation started raising in#165, which didn't include a changelog entry

Copy link
Contributor

@DaraanDaraan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

making ParamSpec.init_subclass raise in the 3.9 implementation, would this be worth a changelog mention? For reference, the 3.10+ implementation started raising in#165, which didn't include a changelog entry.

Imo, it's worth noting. That it is now consistent with the other versions.

@AlexWaygood
Copy link
Member

Thanks for the review! I pushed a few changes. re: makingParamSpec.__init_subclass__ raise in the 3.9 implementation, would this be worth a changelog mention? For reference, the 3.10+ implementation started raising in#165, which didn't include a changelog entry

Probably worth it, just to be safe? I feel like#165probably should have had a changelog mention too if it changed behaviour 😄

brianschubertand others added4 commitsAugust 30, 2025 13:30
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Co-authored-by: Daraan <github.blurry@9ox.net>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great! I think there's a merge conflict

brianschubert reacted with heart emoji
@AlexWaygoodAlexWaygood merged commitccbfd9b intopython:mainAug 30, 2025
23 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

+1 more reviewer

@DaraanDaraanDaraan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianschubert@AlexWaygood@Daraan
[8]ページ先頭
©2009-2025 Movatter.jp