Movatterモバイル変換

Copy link

Member

JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Could you also add a CHANGELOG entry? Look at some of Alex's recent PRs for examples.

src/test_typing_extensions.pyShow resolvedHide resolved

AlexWaygood reviewed

typing_extensions/src/typing_extensions.py

Copy link

Member

AlexWaygood left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We need to change these lines so that we reimplement NamedTuple on <=3.11 rather than <=3.10. Otherwise call-basedtyping_extensions.NamedTuples will have__orig_bases__ on 3.7-3.10 and 3.12+, but not 3.11 😄

Lines 2316 to 2320 infb37b2e

	# Backport typing.NamedTuple as it exists in Python 3.11.
	# In 3.11, the ability to define generic `NamedTuple`s was supported.
	# This was explicitly disallowed in 3.9-3.10, and only half-worked in <=3.8.
	ifsys.version_info>= (3,11):
	NamedTuple=typing.NamedTuple

test_typing_extensions_defers_when_possible will need to be adjusted as a result -- you'll need to move"NamedTuple" into theif sys.version_info < (3, 12) set here:

typing_extensions/src/test_typing_extensions.py

Lines 3610 to 3613 infb37b2e

	ifsys.version_info< (3,11):
	exclude\|= {'final','NamedTuple','Any'}
	ifsys.version_info< (3,12):
	exclude\|= {'Protocol','runtime_checkable','SupportsIndex'}

Copy link

ContributorAuthor

adriangb commentedApr 23, 2023

Could you also add a CHANGELOG entry?

Done, I copied Alex's changelog note from CPython.

release note

ed6d0cf

AlexWaygood reviewed

typing_extensions/src/typing_extensions.py

src/typing_extensions.py

		@@ -813,6 +813,15 @@ def _typeddict_new(args, total=True, *kwargs):
		raise TypeError("TypedDict takes either a dict or keyword arguments,"
		" but not both")

		if kwargs:
		warnings.warn(

Copy link

Member

AlexWaygoodApr 23, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's important that we copy CPython's behaviour here, and CPython emits a deprecation warning here on 3.11+. This PR means we reimplement TypedDict on 3.11 now, so the change is needed, I think.@JelleZijlstra do you think we should only emit the deprecation warning if the user is running typing_extensions on 3.11+? (Referencing#150 (comment))

Copy link

Member

JelleZijlstraApr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's a hard question and gets into what we would do if we ever want to break backwards compatibility for typing-extensions. My first instinct is to say we should always warn in typing-extensions, regardless of the version, but then what would we do when CPython removes support for kwargs-based TypedDicts? I'd be hesitant to remove the runtime behavior in typing-extensions and break backwards compatibility.

Copy link

Member

AlexWaygoodApr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree it's a hard question.

Elsewhere in thetyping_extensions implementation ofTypedDict, we actually already have two places where CPython long ago removed support for a certain feature, buttyping_extensions has in effect had "eternal deprecation warnings":

Lines 789 to 791 infb37b2e

	importwarnings
	warnings.warn("Passing '_typename' as keyword argument is deprecated",
	DeprecationWarning,stacklevel=2)

typing_extensions/src/typing_extensions.py

Lines 804 to 806 infb37b2e

	importwarnings
	warnings.warn("Passing '_fields' as keyword argument is deprecated",
	DeprecationWarning,stacklevel=2)

Copy link

Member

JelleZijlstraApr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think eternal deprecation warnings might be the right answer, actually. (Or eternal until we ever make typing-extensions 5 in the distant uncertain future.)

Copy link

Member

AlexWaygoodApr 23, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So maybe wedo want the change in#150 (comment)? ;)

Copy link

Member

JelleZijlstraApr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, let's do that. I commented there because the change looked unrelated to this PR.

AlexWaygood reviewed

CHANGELOG.mdShow resolvedHide resolved

adriangband others added2 commits

April 23, 2023 13:12

Update CHANGELOG.md

2feff1e

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

Don't skip NamedTuple tests on 3.11+. Also make them pass on 3.11+.

42606d6

AlexWaygood mentioned this pull request

Don't skip NamedTuple tests on 3.11+. Also make them pass on 3.11+.adriangb/typing_extensions#2

Merged

Copy link

Member

AlexWaygood commentedApr 24, 2023

I filedadriangb#2 as a PR to your branch to address my comment above here:#150 (review)

Merge pull request#2from AlexWaygood/typeddict-bases

6365ab1

Don't skip NamedTuple tests on 3.11+. Also make them pass on 3.11+.

AlexWaygood approved these changes

Copy link

Member

AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great to me!

AlexWaygood mentioned this pull request

Add a backport oftypes.get_original_bases#154

Merged

JelleZijlstra approved these changes

src/test_typing_extensions.pyShow resolvedHide resolved

Update src/test_typing_extensions.py

229df6e

JelleZijlstra merged commit1f98818 intopython:main

AlexWaygood added a commit to AlexWaygood/typing_extensions that referenced this pull request

README: Updates re NamedTuple and TypedDict

566e370

Followup topython#150

AlexWaygood mentioned this pull request

README: Updates re NamedTuple and TypedDict#155

Merged

JelleZijlstra pushed a commit that referenced this pull request