- Notifications
You must be signed in to change notification settings - Fork263
Description
Description
There are a few code examples in the docs which import things fromtyping_extensions that are by now available in Python'styping standard library module:
List
typing/docs/guides/unreachable.rst
Line 57 in3149e8c
| from typing_extensionsimport Never |
typing/docs/reference/generics.rst
Line 655 in3149e8c
| from typing_extensionsimport ParamSpec |
... and 4 more occurrences inreference/generics.rst.
typing/docs/reference/protocols.rst
Line 75 in3149e8c
| from typing_extensionsimport Protocol |
... and 4 more occurrences inreference/protocols.rst.
typing/docs/reference/quality.rst
Line 43 in3149e8c
| from typing_extensionsimport assert_type |
It probably makes sense to usetyping imports for all of these instead, possibly with thetyping_extensions alternative mentioned.
How to fix?
What is the policy for these? Should they just be replaced with baretyping imports or something more like
fromtypingimportProtocol# or from typing_extensions for Python < 3.8
?
I haven't seen the latter in any of the other imports, which just import fromtyping without comment (EDIT: at least not in the code itself, but usually it is mentioned as an alternative for older versions somewhere around the code), but who knows...