NotificationsYou must be signed in to change notification settings
Fork1.9k
Star5k

tempfile.SpooledTemporaryFile: inherit from IOBase on 3.11#7802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 13 commits intomasterfromJelleZijlstra-patch-7

May 18, 2022

Merged

tempfile.SpooledTemporaryFile: inherit from IOBase on 3.11#7802

JelleZijlstra merged 13 commits intomasterfromJelleZijlstra-patch-7

May 18, 2022

+25 −15

Conversation

Copy link

Member

JelleZijlstra commentedMay 7, 2022

python/cpython#29560

JelleZijlstraand others added2 commits

May 6, 2022 22:31

tempfile.SpooledTemporaryFile: inherit from IOBase on 3.11

52c19bf

python/cpython#29560

[pre-commit.ci] auto fixes from pre-commit.com hooks

3381dba

This comment has been minimized.

hauntsaninja approved these changes

May 7, 2022

View reviewed changes

AlexWaygood reviewed

May 7, 2022

View reviewed changes

Copy link

Member

AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd prefer us to use a wordier-but-more-readable alias name, like_SpooledTemporaryFileBase, rather than_STFBase which feels a bit opaque.

AlexWaygood reviewed

May 7, 2022

View reviewed changes

stdlib/tempfile.pyi OutdatedShow resolvedHide resolved

Add missing import

5d41486

AlexWaygood reviewed

May 7, 2022

View reviewed changes

Copy link

Member

AlexWaygood left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks like in typeshed, we've always pretended thatSpooledTemporaryFile hasreadable() andseekable() methods on Python <3.11 (see the comment on line 330), even though they don't at runtime. This is becauseSpooledTemporaryFile inherits fromIO in typeshed, andIO hasreadable() andseekable() as abstract methods.