Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
os.popen: add encoding argument for 3.11#7796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
According tomypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Might need to be changed ifpython/cpython#92415 is merged
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also am I missing something obvious or does the original PR not do anything?
Akuli commentedMay 7, 2022
We shouldn't merge this until the argument actually works in cpython. If they ship a broken argument to the next release, it's better to leave it out from the stubs. |
JelleZijlstra commentedMay 19, 2022
The argument was removed again:python/cpython#92836. |
python/cpython#92374