Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
gunicorn 23.0.0, draft#14921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
pajod wants to merge4 commits intopython:mainChoose a base branch frompajod:patch-gunicorn
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
gunicorn 23.0.0, draft#14921
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
According tomypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
pajod commentedOct 25, 2025
Uh oh!
There was an error while loading.Please reload this page.
Contributor
eugeneliukindev commentedOct 26, 2025
@pajod Thank you for finding the inconsistencies and correcting them. I did make a mistake while doing PR. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
for@eugeneliukindev
questions:
notes on things I would like to modify:
FileWrapper.__getitem__is odd, mark the argumentNeverload_classto only classes it is used for viagunicorn.conf.pywrite_errorshall not inject arbitrary str datatimeoutare actually float not int, andgunicorn/workers/sync.pyactually uses thistimeout_ctxmust return a context wrapperThreadWorker.polleris legitimatehandle_request(listener_name)can be either (addr,port) tuples or string (e.g. UNIX sockets)