Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
[CI] Remove hack to run mypy for Python 3.14#14183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
it looks like we might be spending a looooong time building some third-party-stub non-types dependencies from source as part of |
| fi | ||
| # python-version can sometimes be pinned to a specific version or to "-dev", but | ||
| # mypy understands only X.Y version numbers. | ||
| MYPY_PY_VERSION=$(echo ${{ matrix.python-version }} | cut -d - -f 1 | cut -d . -f 1-2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Withhttps://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#allow-pre-releases this wouldn't be needed. Do you see a reason not to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
allow-prereleases won't help with pinning to a specific version or forcing a-dev or-pre release. That said, usingallow-preleases in this specific case is probably the better option.
Not terribly surprising, but that's still a problem, so keeping this as a draft for now. |
No description provided.