Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

@override in_type_checker_internals.TypedDictFallback#14115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jorenham wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromjorenham:TypedDictFallback-override

Conversation

jorenham
Copy link
Contributor

@jorenhamjorenham commentedMay 21, 2025•
edited
Loading

Due to a bug in the pyright github action, the_typeshed._type_checker_internals module is being checked by pyright in the CI ofscipy-stubs. And apparently, was@override one some methods inTypedDictFallback, causing the CI to fail (see e.g.https://github.com/scipy/scipy-stubs/actions/runs/15169287965/job/42655058438?pr=521). And just to be clear, I don't consider this to be the fault of typeshed or anything. I just figured that I might as well add those@override's, for the sake of completeness I suppose 🤷.

@AlexWaygood
Copy link
Member

Hmm, we don't generally decorate methods with@override in typeshed, and there's some debate about whether it would really be useful for us given our existing CI tooling (see#10871)

jorenham reacted with thumbs up emoji

@jorenham
Copy link
ContributorAuthor

Hmm, we don't generally decorate methods with@override in typeshed, and there's some debate about whether it would really be useful for us given our existing CI tooling (see#10871)

Yea I expected something like that, I just thought I'd give it a shot either way. Thanks for the review :)

AlexWaygood reacted with thumbs up emoji

@github-actionsGitHub Actions
Copy link
Contributor

According tomypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jorenham@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp