Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
bump fractions.pyi to 3.14#14070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@sobolevn can you please take a look? |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Don't forget to updatehttps://github.com/python/typeshed/blob/main/stdlib/%40tests/test_cases/builtins/check_pow.py when adding new__pow__ overloads. Basically, any non-Nonemodulo values must be a type-error, seepython/cpython@fcca08e#diff-39381000227588e760871a319e6b5f8e88fc03643b03a94acd2e94b942135e9b
For |
Thanks, I didn't get it quickly :) will add tests |
@sobolevn, okay, but what about these tests? aren't they enough? typeshed/stdlib/@tests/test_cases/builtins/check_pow.py Lines 52 to 53 in1063db7
|
According tomypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
@sobolevn and also here additional check for non-None value of modulo
|
No description provided.