Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bumpenum to 3.14#14021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
donBarbos wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromdonBarbos:bump-enum-3.14
Open

Conversation

donBarbos
Copy link
Contributor

No description provided.

@github-actionsGitHub Actions

This comment has been minimized.

@donBarbosdonBarbos marked this pull request as ready for reviewMay 12, 2025 10:50
@github-actionsGitHub Actions

This comment has been minimized.

Comment on lines 421 to 425
POSITIONAL_ONLY: ClassVar[Literal[0]]
POSITIONAL_OR_KEYWORD: ClassVar[Literal[1]]
VAR_POSITIONAL: ClassVar[Literal[2]]
KEYWORD_ONLY: ClassVar[Literal[3]]
VAR_KEYWORD: ClassVar[Literal[4]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's not true, at least not for Python 3.12:

Python 3.12.3 (main, Feb  4 2025, 14:48:35) [GCC 13.3.0] on linuxType "help", "copyright", "credits" or "license" for more information.>>> import inspect>>> inspect.Parameter.POSITIONAL_ONLY<_ParameterKind.POSITIONAL_ONLY: 0>>>> type(inspect.Parameter.POSITIONAL_ONLY)<enum '_ParameterKind'>

donBarbos reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks you, this was an attempt to solvethis error. apparently I was too hasty in getting the PR ready for review

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suspect it's because you madeenum importinspect and that disturbed some import cycle. As you can see from the mypy-primer report, this change is going to cause a lot of issues.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you're right because these errors appeared when i added import

@github-actionsGitHub Actions
Copy link
Contributor

According tomypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@srittausrittausrittau left review comments

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@donBarbos@srittau@JelleZijlstra

[8]ページ先頭

©2009-2025 Movatter.jp