- Notifications
You must be signed in to change notification settings - Fork618
issue #985#992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
issue #985#992
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fix issue with role attributes
| @@ -13,15 +13,15 @@ <h2 class="widget-title"><span aria-hidden="true" class="icon-success-stories">< | |||
| <a href="{{ story.get_absolute_url }}">{{ story.pull_quote }}</a> | |||
| </blockquote> | |||
| <tablecellpadding="0" cellspacing="0" border="0" width="100%"class="quote-from"> | |||
| <table class="quote-from"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for cleaning up this!
Looks good to me, thanks! I still need to test this in my local setup.
This is probably harmless and can stay.
This is for IE's image toolbar and we can probably remove it. It would be nice to check if it's still useful in Edge. |
Hi, just wanted to follow up on this pull request. Wondering if I should make additional adjustments? |
Sorry, I'm pretty busy with Python 3.6.0 b1 this week (deadline is on 12th) I will try to get this in next week, thanks! In the meantime, it would be great if you can remove the "imagetoolbar" tag I mentioned in#992 (comment). |
No problem. I will get the imagetoolbar tag removed later today. |
Let me know anything else that I should improve on this. |
@Mariatta do you have time to rebase the validate-html branch? (and apologies for my very late response!) |
😅 I also forgot about this PR. If you're in no rush, I'll be able to get back to this in a couple more weeks. |
Of course! I can also work on it, I still have a few hours left from my grant :) |
@berkerpeksag Sounds awesome! I really don't mind if you can take this over. |
Closing in favor of#2536 since I can't push to forks. Commit credits will remain. |
Attempt to address issue#985
removed braile, embossed, tty value from media attribute since they've been deprecated
replaced inline table attributes: cellpadding, cellspacing, width, border, used css
adjust values for role attribute
These two errors remained, but I'm not familiar with these. Any suggestion of what to do here?
Bad value cleartype for attribute http-equiv on element meta.
Bad value imagetoolbar for attribute http-equiv on element meta.