- Notifications
You must be signed in to change notification settings - Fork652
Add featured downloads#2805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
hugovk wants to merge3 commits intopython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+117 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On download pages such ashttps://www.python.org/downloads/release/python-3140/, it's not immediately clear what to click in the big table of a dozen files.
Let's add the most common ones as feature downloads at the top.
Closes#2419
Before
After
Notes
Each "Release" object in the CMS has a number of release files. Some of these have a "Download button" boolean set, max one per OS, which is used for displaying it athttps://www.python.org/downloads/:
Let's also use this flag to decide what to feature here.
(Aside: the flag is set during the release process by
download=Trueinhttps://github.com/python/release-tools/blob/d8077eae1dcea2653775e4b3ba9f51700b354f5e/add_to_pydotorg.py#L105-L190.)Windows
However, for Windows, let's use the Python install manager and link tohttps://www.python.org/downloads/latest/pymanager/ using similar logic for the button athttps://www.python.org/downloads/
That page says:
Re: "The install manager can install versions of Python as far back as 3.5"
So let's only show the install manager for downloads of 3.5 and later. Older ones can use the file set by the CMS. For example, for 3.4.0:
Re: "but only supports Windows 10 operating systems (or Windows Server 2022) and later"
For the purpose of this featured release for 3.5+, it's fine to cater for the common case of new Windows (especially as Win10 is EOL). The full list is right there if you need a file.
@zooba How does this sound?