Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: sanitize release names upon submission#2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JacobCoffee wants to merge5 commits intomain
base:main
Choose a base branch
Loading
from2724-sanitize-release-name

Conversation

JacobCoffee
Copy link
Member

@JacobCoffeeJacobCoffee commentedMay 6, 2025•
edited
Loading

Description

  • Clean release name field to ensure no errors when loading release pages

Closes#2724

Copilot

This comment was marked as abuse.

@ewdurbin
Copy link
Member

@JacobCoffee is there an issue associated with this PR? I mean it makes sense but hard to say if it is "correct" without some documenting reason.

@JacobCoffee
Copy link
MemberAuthor

yeah sorry, i thought if i put it in the commit message it would link it

Copy link
Member

@ewdurbinewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would recommend using aValidator rather than overriding clean.

JacobCoffee reacted with eyes emoji
@JacobCoffeeJacobCoffee requested a review fromewdurbinMay 6, 2025 15:33
@JacobCoffee
Copy link
MemberAuthor

JacobCoffee commentedMay 6, 2025•
edited
Loading

doh...

before i do all the migrations and things, do you think overriding the name on the NameSlugModel and adding the validator is still the best path@ewdurbin? I'm okay with either just wanting to make sure

@JacobCoffeeJacobCoffee changed the titlefeat: sanitze release names upon submissionfeat: sanitize release names upon submissionMay 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@ewdurbinewdurbinAwaiting requested review from ewdurbinewdurbin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Sanitize release names to require string
2 participants
@JacobCoffee@ewdurbin
[8]ページ先頭
©2009-2025 Movatter.jp