Instead of using a particular resolution on an object, which differs betweendatetime.date anddatetime.datetime objects, operate on parent class ofdatetime and convert alldt to timezone-awaredatetime values.

This is also in accordance to the model field being aDateTimeField, so we should always be passing the correctly-created object, instead of adatetime.date(), raisingreceived a naive datetime warnings.

Removes unused constants.

Closes

Closes#2415

Other notes, for fun.

The warnings stem from this little bitty function:

pythondotorg/events/utils.py

Lines 23 to 26 in8a02c10

	defextract_date_or_datetime(dt):
	ifisinstance(dt,datetime.datetime):
	returnconvert_dt_to_aware(dt)
	returndt

Since the ICS importer is often met with a string that looks like a date-only, like this one:

pythondotorg/events/tests/test_importer.py

Line 39 in8a02c10

DTSTART;VALUE=DATE:20160402

the returned type isdatetime.date, not adatetime.datetime.

The change inevents/utils.py drops the warnings, but fails two test cases:

======================================================================FAIL: test_import_event_excludes_ending_day_when_all_day_is_true (events.tests.test_importer.EventsImporterTestCase.test_import_event_excludes_ending_day_when_all_day_is_true)----------------------------------------------------------------------Traceback (most recent call last):  File "/code/events/tests/test_importer.py", line 131, in test_import_event_excludes_ending_day_when_all_day_is_true    self.assertTrue(all_day_event.next_or_previous_time.all_day)AssertionError: False is not true======================================================================FAIL: test_modified_event (events.tests.test_importer.EventsImporterTestCase.test_modified_event)----------------------------------------------------------------------Traceback (most recent call last):  File "/code/events/tests/test_importer.py", line 63, in test_modified_event    self.assertTrue(e.next_or_previous_time.all_day)AssertionError: False is not true

These come from theall_day calculation over here:

pythondotorg/events/importer.py

Lines 33 to 37 in74e659c

	# Let's mark those occurrences as 'all-day'.
	all_day= (
	dt_start.resolution==DATE_RESOLUTIONor
	dt_end.resolution==DATE_RESOLUTION
	)

which has now been updated.

refactor: updateall_day detection logic

b12e856

Instead of using a particular resolution on an object, which differsbetween `datetime.date` and `datetime.datetime` objects, operate onparent class of `datetime` and convert all `dt` to timezone-aware`datetime` values.This is also in accordance to the model field being a `DateTimeField`,so we should always be passing the correctly-created object, instead ofa `datetime.date()`, raising `received a naive datetime` warnings.Removes unused constants.Signed-off-by: Mike Fiedler <miketheman@gmail.com>

miketheman requested review fromewdurbin andJacobCoffee ascode owners

September 20, 2024 22:11

miketheman mentioned this pull request

Sep 20, 2024

Tests: Silence naive datetime warning spam#2415

Closed

miketheman added2 commits

September 24, 2024 10:35

Merge branch 'main' into miketheman/fix-naive-date-to-datetime

ef2fd43

Merge branch 'main' into miketheman/fix-naive-date-to-datetime

d73a3b3