Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

give admin user a preview of sponsorship package revenue splits#2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ewdurbin merged 2 commits intopython:mainfromindepndnt:sponsorship-splits
Sep 12, 2024
Merged

give admin user a preview of sponsorship package revenue splits#2529

ewdurbin merged 2 commits intopython:mainfromindepndnt:sponsorship-splits
Sep 12, 2024

Conversation

indepndnt
Copy link
Contributor

This adds information to the admin screen for Sponsorship Packages about the revenue split for unmodified sponsorships.

Screenshot from 2024-09-11 08-17-52

ewdurbin reacted with heart emoji
Copy link
Member

@ewdurbinewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A couple of suggestions after running this locally.

I'm +1 to this if we add a bit stronger of a test, perhaps having multiple packages with multiple different values.

@indepndnt
Copy link
ContributorAuthor

Thanks Ee! I had initially thought about using the Python colors but then I went a different way. I beefed up the test and applied your suggestions.

ewdurbin reacted with heart emoji

@ewdurbin
Copy link
Member

Thanks@indepndnt, this looks great!

indepndnt reacted with hooray emoji

@ewdurbinewdurbin merged commitce1c391 intopython:mainSep 12, 2024
2 checks passed
ewdurbin added a commit that referenced this pull requestSep 12, 2024
A small, hard to notice change was present in my suggestion that wasn't picked up.
ewdurbin added a commit that referenced this pull requestSep 12, 2024
A small, hard to notice change was present in my suggestion that wasn't picked up.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ewdurbinewdurbinewdurbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@indepndnt@ewdurbin
[8]ページ先頭
©2009-2025 Movatter.jp