- Notifications
You must be signed in to change notification settings - Fork619
fix(#1701): Events page displays year for events scheduled to start or end at a future year#2500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
15 commits Select commitHold shift + click to select a range
1502c10
Add Methods To Check If Event Starts And Ends This Year
alvindera974198812
Set Up Templates For Querying Start And End Years
alvindera97ff1ad8b
Insert New Test Data And Update test_views.py
alvindera97e3125d9
Time Tag Now Shows Year For Events With Details Not Within The Curren…
alvindera97178742b
Move All Test Data To Functional Test
alvindera97e0fdf7c
Functional Test For Displaying Year Of Event For Future Events Now Im…
alvindera97115af08
Remove Functional Test For Displaying Year Of Future Event
alvindera97aa4d55b
Handle Case When Call To Next Event Returns None
alvindera97207a0af
Fix Erroneous Addition To Dev Requirements
alvindera97c7cfabd
Merge remote-tracking branch 'upstream/main' into fix-issue-1701
alvindera97fa6e0ce
Merge branch 'main' into fix-issue-1701
JacobCoffee6a18a62
Refactor Tests For Relevant Year String Rendering At Events Page
alvindera9723569b9
Merge remote-tracking branch 'origin/main' into fix-issue-1701
alvindera97c4db8d4
Merge remote-tracking branch 'upstream/main' into fix-issue-1701
alvindera971150e6a
Merge branch 'main' into fix-issue-1701
JacobCoffeeFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,32 @@ | ||
{% if next_time.single_day %} | ||
<time datetime="{{ next_time.dt_start|date:'c' }}">{{ next_time.dt_start|date:"d N" }} | ||
<span id="start-{{ object.id }}"{% if scheduled_start_this_year %} class="say-no-more"{% endif %}> | ||
{{ next_time.dt_start|date:"Y" }} | ||
</span> | ||
<span id="start-{{ object.id }}"{% if scheduled_end_this_year %} class="say-no-more"{% endif %}> | ||
{{ next_time.dt_start|date:"Y" }} | ||
</span> | ||
{% if not next_time.all_day %} | ||
{{ next_time.dt_start|date:"fA"|lower }} {{ next_time.dt_start|date:"e" }} | ||
{% if next_time.valid_dt_end %} – {{ next_time.dt_end|date:"fA"|lower }} | ||
{{ next_time.dt_end|date:"e" }} | ||
{% endif %} | ||
{% endif %} | ||
</time> | ||
{% else %} | ||
<time datetime="{{ next_time.dt_start|date:'c' }}">{{ next_time.dt_start|date:"d N" }} | ||
<span id="start-{{ object.id }}"{% if scheduled_start_this_year %} class="say-no-more"{% endif %}> | ||
{{ next_time.dt_start|date:"Y" }} | ||
</span> | ||
{% if next_time.valid_dt_end %} – | ||
{{ next_time.dt_end|date:"d N" }} | ||
{% endif %} | ||
<span id="end-{{ object.id }}"{% if scheduled_end_this_year %} class="say-no-more"{% endif %}> | ||
{{ next_time.dt_end|date:"Y" }} | ||
</span> | ||
</time> | ||
{% endif %} |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.