- Notifications
You must be signed in to change notification settings - Fork618
fix(frontend): Improve low constrast of code blocks and links#2491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I only checked the green so far, looks better. Before: ![]() After: ![]() You know, I might be tempted to drop that rounded grey background box altogether, we don't have that sort of thing athttps://docs.python.org/3/whatsnew/3.12.html, or keep the grey background but drop the shadow and rounder border radius. ![]() ![]() (Possibly also ditching the green?) ![]() ![]() |
Could also decrease the padding.. It looks pretty big |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks for your first contribution,@tomasr8 :)
Closes#2446
I changed the code block color for the closest darker green that surpasses
4.5
- Firefox is now reporting it as4.57
.I didn't want to change the link color for all links, so I just added a new rule to target links in tables only. Firefox now reports the new value as
4.56
.Let me know if it's ok like this!