Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(frontend): Improve low constrast of code blocks and links#2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tomasr8 wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromtomasr8:a11y

Conversation

tomasr8
Copy link
Member

Closes#2446

I changed the code block color for the closest darker green that surpasses4.5 - Firefox is now reporting it as4.57.

I didn't want to change the link color for all links, so I just added a new rule to target links in tables only. Firefox now reports the new value as4.56.

Let me know if it's ok like this!

@hugovk
Copy link
Member

I only checked the green so far, looks better.

Before:

image

After:

image

You know, I might be tempted to drop that rounded grey background box altogether, we don't have that sort of thing athttps://docs.python.org/3/whatsnew/3.12.html, or keep the grey background but drop the shadow and rounder border radius.

imageimage

(Possibly also ditching the green?)

imageimage

@tomasr8
Copy link
MemberAuthor

Could also decrease the padding.. It looks pretty big

@JacobCoffee
Copy link
Member

I think I like this the best out of the options:

image

but the current "After:" state is good, too.

Copy link
Member

@JacobCoffeeJacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for your first contribution,@tomasr8 :)

hugovk and tomasr8 reacted with hooray emoji
@JacobCoffeeJacobCoffee changed the title[a11y] Improve low constrast of code blocks and linksfix(frontend): Improve low constrast of code blocks and linksSep 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JacobCoffeeJacobCoffeeJacobCoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A11y: Contrast of code formatting too low
3 participants
@tomasr8@hugovk@JacobCoffee

[8]ページ先頭

©2009-2025 Movatter.jp