python/pythondotorgPublic

NotificationsYou must be signed in to change notification settings
Fork621
Star1.6k

Fix jobs/tests/test_models.py misusing`assertTrue`#1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ewdurbin merged 2 commits intopython:mainfromcode-review-doctor:fix-avoid-misusing-assert-true

Sep 13, 2024

Merged

Fix jobs/tests/test_models.py misusing`assertTrue`#1987

ewdurbin merged 2 commits intopython:mainfromcode-review-doctor:fix-avoid-misusing-assert-true

Sep 13, 2024

Conversation

Copy link

Contributor

code-review-doctor commentedFeb 15, 2022

Fixes#1986

Fix issue avoid-misusing-assert-true found athttps://codereview.doctor

ed676e5

rbanffy approved these changes

Feb 16, 2022

View reviewed changes

Copy link

rbanffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

rbanffy approved these changes

Feb 16, 2022

View reviewed changes

Copy link

rbanffy left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry. Not a full-time contributor. At least I had an approve button ;-)

ambv changed the title~~Some tests misusing assertTrue for comparisons fix~~Fix jobs/tests/test_models.py misusingassertTrue

Mar 11, 2024

ambv approved these changes

Mar 11, 2024

View reviewed changes

Copy link

Contributor

ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a valid fix, and a straightforward change.

Copy link

Member

hugovk commentedMar 11, 2024

Here's some others, found usinghttps://github.com/isidentical/teyit.

assert_ was removed in 3.12:https://docs.python.org/3/whatsnew/3.12.html#id3

diff --git a/downloads/tests/test_models.py b/downloads/tests/test_models.pyindex f27e951..d31afae 100644--- a/downloads/tests/test_models.py+++ b/downloads/tests/test_models.py@@ -82,8 +82,8 @@ class DownloadModelTests(BaseDownloadTests):          release_38 = Release.objects.create(name='Python 3.8.0')         self.assertFalse(release_38.is_version_at_least_3_9)-        self.assert_(release_38.is_version_at_least_3_5)+        self.assertTrue(release_38.is_version_at_least_3_5)          release_310 = Release.objects.create(name='Python 3.10.0')-        self.assert_(release_310.is_version_at_least_3_9)-        self.assert_(release_310.is_version_at_least_3_5)+        self.assertTrue(release_310.is_version_at_least_3_9)+        self.assertTrue(release_310.is_version_at_least_3_5)