- Notifications
You must be signed in to change notification settings - Fork624
Check package only benefits as well#1670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
A package only benefit's checkbox is rendered in the HTML with thedisabled attribute. Because of that, the click event wasn't beingtriggered by the browser. This fix turn off and on this attribute sothe click event can happen.
ewdurbin approved these changesNov 12, 2020
ewdurbin added a commit that referenced this pull requestNov 12, 2020
A package only benefit's checkbox is rendered in the HTML with thedisabled attribute. Because of that, the click event wasn't beingtriggered by the browser. This fix turn off and on this attribute sothe click event can happen.Co-authored-by: Bernardo Fontes <bernardoxhc@gmail.com>
ewdurbin added a commit that referenced this pull requestNov 12, 2020
* Check package only benefits as well (#1670)A package only benefit's checkbox is rendered in the HTML with thedisabled attribute. Because of that, the click event wasn't beingtriggered by the browser. This fix turn off and on this attribute sothe click event can happen.* Update CSS to fit 4 sponsorship programs (#1673)Co-authored-by: Bernardo Fontes <bernardoxhc@gmail.com>
ewdurbin added a commit that referenced this pull requestNov 16, 2020
A package only benefit's checkbox is rendered in the HTML with thedisabled attribute. Because of that, the click event wasn't beingtriggered by the browser. This fix turn off and on this attribute sothe click event can happen.Co-authored-by: Bernardo Fontes <bernardoxhc@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A package only benefit's checkbox is rendered in the HTML with the
disabled attribute. Because of that, the click event wasn't being
triggered by the browser. This fix turn off and on this attribute so
the click event can happen.